Repository navigation
test(wework): harden cloud terminal e2e workspace roots - #2492
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe desktop E2E flow now retains workspace-related test IDs in snapshot diagnostics and sets ChangesWorkspace E2E flow
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
qdaxb
marked this pull request as ready for review
August 7, 2026 10:17
qdaxb
enabled auto-merge
August 7, 2026 10:17
qdaxb
added this pull request to the merge queue
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
Wework 云端桌面 E2E 偶发在首次打开项目终端时失败。远端 executor 返回
Project path is outside allowed workspace roots,导致终端卡片进入“启动失败”状态,测试最终以等待终端窗口超时结束。根因
测试创建的云端项目 workspace 位于临时结果目录中,但远端 executor 只通过
LOCAL_WORKSPACE_ROOT间接获得较宽泛的目录边界,没有使用 executor 为额外工作区提供的显式 allow-list 配置。环境状态异常时,session 路径校验可能无法确认该 workspace。同时,通用快照超时诊断没有保留 workspace 面板相关的 test ID,失败日志只显示 composer 控件,掩盖了实际的终端启动失败状态。
修改
WEGENT_WORKSPACE_ROOTS显式声明本次云端 workspace。workspace-*和bottom-workspace-*test ID,便于直接识别终端、launcher 和底部面板状态。影响
云端桌面 E2E 的终端路径边界配置变得确定,不再依赖隐式目录覆盖;若终端流程再次失败,CI 日志也会包含直接相关的 UI 状态。
验证
node --check wework/e2e/desktop/task-flow.e2e.mjspnpm --filter wework exec prettier --check e2e/desktop/task-flow.e2e.mjspnpm --filter wework exec eslint e2e/desktop/task-flow.e2e.mjspnpm --filter wework e2e:desktop:cloudSummary by CodeRabbit