Repository navigation
fix(wework): keep live reasoning preview visible #2390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
364e31c
fix(wework): keep live reasoning preview visible
qdaxb e767d71
fix(wework): scope reasoning preview to active phase
qdaxb e15a49d
fix(wework): harden reasoning preview checks
qdaxb 2428eeb
test(wework): await completed reasoning turn
qdaxb bfed131
fix(wework): preserve restored runtime state
qdaxb 2d8a92b
Merge remote-tracking branch 'origin/main' into fix/wework-keep-live-…
qdaxb 17b0a95
Merge remote-tracking branch 'origin/main' into fix/wework-keep-live-…
qdaxb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,42 @@ | ||
| import { useTranslation } from '@/hooks/useTranslation' | ||
|
|
||
| export function AssistantThinkingIndicator() { | ||
| const THINKING_PREVIEW_MAX_LENGTH = 96 | ||
|
|
||
| export function AssistantThinkingIndicator({ | ||
| content = '', | ||
| testId = 'thinking-indicator', | ||
| }: { | ||
| content?: string | ||
| testId?: string | ||
| }) { | ||
| const { t } = useTranslation('chat') | ||
| const preview = buildThinkingPreview(content) | ||
| const text = preview ? `${t('thinking.running')} · ${preview}` : t('thinking.running') | ||
|
|
||
| return ( | ||
| <div className="inline-flex items-center text-sm" data-testid="thinking-indicator"> | ||
| <span className="waiting-thinking-text">{t('thinking.running')}</span> | ||
| <div className="inline-flex min-w-0 max-w-full items-center text-sm" data-testid={testId}> | ||
| <span className="waiting-thinking-text min-w-0 truncate">{text}</span> | ||
| </div> | ||
| ) | ||
| } | ||
|
|
||
| function buildThinkingPreview(content: string): string { | ||
| const normalized = content | ||
| .replace(/```[\s\S]*?```/g, ' ') | ||
| .replace(/`([^`]*)`/g, '$1') | ||
| .replace(/[#>*_[\]()-]+/g, ' ') | ||
| .replace(/\s+/g, ' ') | ||
| .trim() | ||
|
|
||
| if (!normalized) return '' | ||
|
|
||
| const segments = normalized | ||
| .split(/[。!?!?]+|\.(?=\s|$)/) | ||
| .map(segment => segment.trim()) | ||
| .filter(Boolean) | ||
| const preview = segments[segments.length - 1] ?? normalized | ||
|
|
||
| return preview.length <= THINKING_PREVIEW_MAX_LENGTH | ||
| ? preview | ||
| : `${preview.substring(0, THINKING_PREVIEW_MAX_LENGTH)}...` | ||
|
coderabbitai[bot] marked this conversation as resolved.
Resolved
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.