Repository navigation
fix(wework): pause and recover queued messages safely - #2266
Merged
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThis PR documents queued follow-up behavior, adjusts queue pausing around runtime cancellation, and adds desktop E2E coverage for reordering, pausing, resuming, preserving, and clearing queued messages. ChangesQueued follow-up management
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
qdaxb
marked this pull request as ready for review
July 28, 2026 05:11
This was referenced Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Stopping the active response awaited runtime cancellation before marking the message queue as paused. The cancellation could transition the task to idle first, allowing the automatic queue dispatcher to send the next item. The queue is now paused before cancellation and rolled back only when cancellation fails.
The previous desktop drag helper emitted every pointer event in one render frame, so the sortable interaction could not activate consistently. It now advances across render ticks and emits movement on the target before release.
Validation
pnpm --filter wework typecheckpnpm --filter wework test— 226 files, 2261 tests passedpnpm --dir wework exec vitest run src/components/chat/ChatInput.test.tsx— 98 tests passedpnpm --dir wework exec node e2e/desktop/task-flow.e2e.mjs --queue-management-onlySummary by CodeRabbit
New Features
Bug Fixes
Documentation