Repository navigation
fix(wework): route desktop scenario captures through the platform-aware helper - #2253
Merged
Merged
Conversation
…re helper The desktop scenarios called the webview capture command directly, which invokes the macOS-only capture_main_webview Tauri command. Since e2e:desktop now always loads the streaming-text scenario, the Linux Core job failed with 'Main webview snapshots are currently supported on macOS only'. Pass the runner's captureVerificationScreenshot into scenarios so captures use ImageMagick on Linux and webview snapshots on macOS.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughDesktop E2E scenarios no longer write screenshots directly. They accept an injected ChangesDesktop screenshot capture
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
Wework Desktop E2E (Core) 在 Linux 上报错:
根因
#2250 把
e2e:desktop改为始终加载 streaming-text 场景。场景内的capture()直接调用 webview 的capture控制命令,底层走 Tauri 的capture_main_webview,而该命令只在 macOS 上实现(desktop_capture.rs)。Linux Core 任务在场景末尾截图时因此失败。修复
把 runner 中已有的平台感知截图助手
captureVerificationScreenshot(Linux 用 ImageMagickimport -window root,macOS 用 webview 快照)通过createDesktopScenario选项注入,三个桌面场景(streaming-text / cloud-space-mention / conversation-mention)统一改走该助手,删除各自重复的capture()实现。验证
pnpm --filter wework test:222 个测试文件、2223 个用例全部通过e2e:desktop:streaming-text:新截图链路正常工作(streaming-text-00-ready-to-send.png成功产出);后续在 waitFor 阶段超时,已用未修改的 origin/main 对照复现同样失败(本地 codex-cli 0.144.5 未转发模型请求,0 条 model requests),确认与本次改动无关Summary by CodeRabbit