Repository navigation
fix(wework): top-align short conversations - #2173
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughChangesThe change gates message virtualization behind a 20-message minimum and adds a desktop E2E regression flow that reopens short conversations, records layout metrics, captures screenshots, and enforces a 160px top-offset limit. English and Chinese guides document the workflow and artifacts. Short-conversation layout verification
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant DesktopE2ERunner
participant fresh_chat
participant MessageList
participant desktopControlElementMetrics
DesktopE2ERunner->>fresh_chat: Submit prompt and follow-up
fresh_chat-->>DesktopE2ERunner: Complete expected scenario requests
DesktopE2ERunner->>MessageList: Reopen selected conversation
DesktopE2ERunner->>desktopControlElementMetrics: Collect message bounds
desktopControlElementMetrics-->>DesktopE2ERunner: Return layout metrics
Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
e2e:desktopfresh-chat flowRoot cause
Tauri message virtualization was enabled even for short conversations. After a short two-turn conversation was switched away from and reopened, estimated virtual row heights could leave a large blank area above the first rendered message.
Impact
Short conversations now reopen with their first message near the top of the message viewport. Long conversations keep the existing virtualized rendering and memory behavior.
Validation
194pxtop offset; fixed condition passed with a32pxtop offsetpnpm --filter wework lintpnpm --filter wework typecheckpnpm --filter wework test— 206 files, 2032 tests passedSummary by CodeRabbit
Bug Fixes
Testing
Documentation