Repository navigation
fix(wework): restore guidance text when editing - #2164
Merged
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthrough
ChangesComposer draft buffering
Estimated code review effort: 2 (Simple) | ~15 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
qdaxb
marked this pull request as ready for review
July 23, 2026 16:41
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
After submitting guidance text,
BufferedChatInputassociated its empty local draft with the text that had just been submitted. When the same text was returned from the guidance row for editing, the buffer treated it as the previous source value and kept rendering the empty draft.This change associates the post-submit empty draft with the expected empty external value, so editing a queued guidance row restores its text correctly.
Impact
Clicking Edit on a queued guidance entry now places the entry text back into the Wework composer as expected.
Validation
pnpm --filter wework exec vitest run src/components/layout/BufferedChatInput.test.tsx src/components/chat/ChatInput.test.tsx(99 tests passed)git diff --checkpassedSummary by CodeRabbit
Bug Fixes
Documentation
Tests