Repository navigation
fix(wework): show thinking below streaming responses - #2154
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughThe PR updates streamed assistant-message thinking-indicator behavior, adds component expectations for the new lifecycle, and introduces a desktop E2E scenario that mocks partial Responses SSE output and verifies screenshots, completion, and scenario-specific Codex configuration. ChangesStreaming text regression
Estimated code review effort: 3 (Moderate) | ~30 minutes Sequence Diagram(s)sequenceDiagram
participant DesktopUI
participant TaskFlow
participant StreamingScenario
DesktopUI->>TaskFlow: send streaming-text prompt
TaskFlow->>StreamingScenario: POST Responses request
StreamingScenario-->>DesktopUI: partial assistant SSE events
DesktopUI-->>StreamingScenario: visible reply and thinking indicator
StreamingScenario-->>DesktopUI: completion SSE events after release
DesktopUI-->>TaskFlow: completed reply without thinking indicator
Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Checkov (3.3.8)wework/package.jsonTraceback (most recent call last): Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
b2fd7a3 to
4961866
Compare
Summary
Root cause
The message renderer only showed the thinking indicator before any visible assistant content existed. Once final text began streaming, the indicator was suppressed even though the response was still active.
Validation
pnpm --filter wework test— 200 files, 2002 tests passedpnpm --filter wework e2e:desktop:streaming-textpassed in a real Tauri app with real Executor and Codex app-serverSummary by CodeRabbit
New Features
e2e:desktop:streaming-textcommand for running the scenario.Bug Fixes
Documentation