Repository navigation
feat(wework): prevent sleep while tasks run - #2122
Merged
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (18)
📝 WalkthroughWalkthroughAdds a default-enabled “prevent sleep while tasks are running” preference, platform-specific sleep inhibition, active-task tray propagation, executor cleanup, UI controls, tests, macOS E2E verification, and English/Chinese documentation. ChangesSleep inhibition during running tasks
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant GeneralSettingsPage
participant update_app_preferences
participant SystemSleepState
participant SleepInhibitor
GeneralSettingsPage->>update_app_preferences: update preventSleepWhileTasksRunning
update_app_preferences->>SystemSleepState: set_enabled preference
SystemSleepState->>SleepInhibitor: acquire while active tasks exist
SystemSleepState->>SleepInhibitor: release after tasks settle
Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
qdaxb
marked this pull request as ready for review
July 22, 2026 09:28
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
caffeinate), Windows (SetThreadExecutionState), and Linux (systemd-inhibit)Why
Long-running local tasks can be interrupted when the computer enters idle sleep. Wework should keep the system awake only for the duration of active work, without changing the user's configured sleep policy or forcing the computer to sleep afterward.
User impact
The new setting is enabled by default. Users can disable it at any time; doing so immediately releases the inhibitor. When all tasks finish, fail, or are interrupted, Wework restores normal system sleep behavior.
Validation
pnpm --filter wework test— 194 files, 1933 tests passedpnpm --filter wework exec tsc --noEmitcargo test --manifest-path wework/src-tauri/Cargo.toml --lib— 84 tests passed on latestorigin/mainpnpm --filter wework e2e:desktop:lifecycle— passed in an isolated real Tauri appSummary by CodeRabbit
New Features
Bug Fixes
Tests