Repository navigation
fix(wework): isolate sidebar chat attachments - #2115
Merged
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (14)
📝 WalkthroughWalkthroughChangesTemporary chat runtime flow
AI-verify file-drop command
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant BufferedChatInput
participant TemporaryChatPanel
participant createTemporaryRuntimeTask
participant buildSendPayload
BufferedChatInput->>TemporaryChatPanel: provide side-chat attachments
TemporaryChatPanel->>createTemporaryRuntimeTask: send attachments
createTemporaryRuntimeTask->>buildSendPayload: build payload with attachments
Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
qdaxb
force-pushed
the
fix/sidebar-chat-attachments
branch
from
July 22, 2026 07:32
cb0aba1 to
ff58cd0
Compare
qdaxb
marked this pull request as ready for review
July 22, 2026 07:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
threadIdvalues while converting and reconciling work-list task addressesRoot cause
TemporaryChatPanelreused the main composer'sprojectChatattachment controls, so both composers rendered the same attachment collection. The split hook also treated 420px as the main-chat width for every right-workspace view, leaving a lone temporary chat unnecessarily wide.Real-Tauri verification then exposed a second issue: work-list task address conversion dropped the top-level
threadId. A hydrated main conversation could therefore be rejected as an invalid side-chat source when its runtime handle did not repeat that thread id.Validation
pnpm --filter wework test(195 files, 1935 tests)pnpm --filter wework typecheckimage.png: upload remained only in the side composer, the 420px side panel remained compact, the image was sent to the temporary thread, the model described it, and the side composer attachment clearedSummary by CodeRabbit
New Features
Documentation
Tests