Skip to content

fix(wework): raise parallel pane limit to 20 - #2047

Merged
qdaxb merged 1 commit into
mainfrom
fix/wework-parallel-pane-limit
Jul 19, 2026
Merged

qdaxb merged 1 commit into
mainfrom
fix/wework-parallel-pane-limit

Conversation

@qdaxb

@qdaxb qdaxb commented Jul 18, 2026 •

Copy link
Copy Markdown
Contributor

What changed

  • Raise the desktop Wework cached parallel pane limit from 10 to 20.
  • Document the pane cache boundary and its LRU/pinning behavior in Chinese and English.

Why

Users running more than 10 tasks in parallel could have an inactive pane evicted, which discarded its in-memory message, composer draft, and local UI state. Increasing the regular pane cache limit allows up to 20 parallel panes to retain that state while preserving the existing eviction and pinning behavior.

Impact

Desktop Wework now keeps up to 20 regular workbench panes mounted. Running-task panes and panes with pinned terminals continue to remain mounted outside the regular limit.

Validation

  • pnpm --filter wework exec prettier --check src/components/layout/DesktopWorkbenchMain.tsx
  • pnpm --filter wework exec eslint src/components/layout/DesktopWorkbenchMain.tsx
  • Wework unit tests: 180 files, 1799 tests passed
  • Pre-push ESLint, TypeScript, and unit tests passed
  • Isolated real-Tauri verification completed with desktop-workbench-content visible and a captured screenshot

Summary by CodeRabbit

  • New Features

    • Increased the number of desktop workbench panes that can be cached from 10 to 20.
    • Preserves messages, drafts, and local pane state across more task switches.
  • Documentation

    • Added English and Chinese guidance covering pane caching, eviction behavior, running tasks, and pinned terminals.

@coderabbitai

coderabbitai Bot commented Jul 18, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a132fd9d-888e-4857-8dae-fdc3d96342f0

📥 Commits

Reviewing files that changed from the base of the PR and between 1d927af and ae0e53f.

📒 Files selected for processing (3)
  • docs/en/developer-guide/wework-chat-state-sources.md
  • docs/zh/developer-guide/wework-chat-state-sources.md
  • wework/src/components/layout/DesktopWorkbenchMain.tsx

📝 Walkthrough

Walkthrough

The desktop workbench cache limit increases from 10 to 20 regular panes. English and Chinese developer documentation describe LRU eviction, retention exceptions for running tasks and pinned terminals, and reuse of CachedWorkbenchPaneStack.

Changes

Workbench pane cache

Layer / File(s) Summary
Cache capacity and documented retention rules
wework/src/components/layout/DesktopWorkbenchMain.tsx, docs/*/developer-guide/wework-chat-state-sources.md
The regular desktop pane cache limit increases to 20, while documentation records LRU eviction, retention exceptions, and the existing cache and pinning mechanisms.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: increasing the Wework parallel pane limit to 20.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/wework-parallel-pane-limit

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qdaxb
qdaxb marked this pull request as ready for review July 18, 2026 19:07
@qdaxb
qdaxb merged commit e02ff71 into main Jul 19, 2026
30 checks passed
@qdaxb
qdaxb deleted the fix/wework-parallel-pane-limit branch July 19, 2026 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant