Skip to content

fix(wework): hide apps icon from titlebar - #1974

Merged
qdaxb merged 1 commit into
mainfrom
fix/hide-wework-apps-icon
Jul 15, 2026
Merged

qdaxb merged 1 commit into
mainfrom
fix/hide-wework-apps-icon

Conversation

@qdaxb

@qdaxb qdaxb commented Jul 15, 2026 •

Copy link
Copy Markdown
Contributor

What changed

  • Hide the Apps icon from the Wework desktop titlebar and sidebar chrome controls.
  • Keep the /apps route and app center route resolution available.
  • Update navigation and layout tests to assert that the Apps icon is not rendered.

Why

The Apps entry should no longer be exposed in the top-level Wework chrome, while preserving the underlying app center for direct navigation and existing internal flows.

Impact

Wework users no longer see the Apps icon in the top bar. No API, persistence, or route behavior changes.

Validation

  • Prettier check
  • ESLint
  • TypeScript
  • Wework unit tests
  • Focused tests: 143 passed

Real Tauri verification was attempted in an isolated session, but the local runtime remained on the startup screen and timed out before the titlebar became available. The session was stopped and cleaned up.

Summary by CodeRabbit

  • UI Changes

    • Removed the Apps tab from the desktop title bar.
    • Updated the WeWork tab styling and layout.
    • Apps routes continue to preserve their active application state without displaying a separate Apps tab.
  • Tests

    • Updated route and navigation coverage to reflect the hidden Apps tab and revised title bar behavior.

@coderabbitai

coderabbitai Bot commented Jul 15, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cedb3fc2-8020-47fa-a637-201d6a698394

📥 Commits

Reviewing files that changed from the base of the PR and between b00ccff and cfe11bf.

📒 Files selected for processing (6)
  • wework/src/App.apps.test.tsx
  • wework/src/components/layout/DesktopSidebar.tsx
  • wework/src/components/layout/DesktopWorkbenchLayout.test.tsx
  • wework/src/components/layout/DesktopWorkbenchLayout.tsx
  • wework/src/components/topnav/useChromeTabs.test.ts
  • wework/src/config/apps.ts

📝 Walkthrough

Walkthrough

The Apps chrome tab is marked hidden, removed from desktop sidebar chrome controls and navigation wiring, and covered by updated route and layout tests. Active application state remains resolved for hidden routes.

Changes

Chrome tab visibility

Layer / File(s) Summary
Hidden tab configuration and route expectations
wework/src/config/apps.ts, wework/src/components/topnav/useChromeTabs.test.ts
The Apps tab is marked hidden; tests expect hidden tabs to be excluded while preserving active application state.
Sidebar chrome removal and validation
wework/src/components/layout/DesktopSidebar.tsx, wework/src/components/layout/DesktopWorkbenchLayout.tsx, wework/src/App.apps.test.tsx, wework/src/components/layout/DesktopWorkbenchLayout.test.tsx
Apps chrome rendering, its callback prop, icon, label, and /apps navigation wiring are removed; layout tests verify the remaining WeWork control and absent Apps control.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: micro66

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/hide-wework-apps-icon

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qdaxb
qdaxb marked this pull request as ready for review July 15, 2026 08:28
@qdaxb
qdaxb merged commit 1f2c977 into main Jul 15, 2026
12 of 13 checks passed
@qdaxb
qdaxb deleted the fix/hide-wework-apps-icon branch July 15, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant