Repository navigation
fix(wework): restore macOS dock window lifecycle - #1928
Merged
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughAdds a ChangesClose-to-tray verification
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant AIVerifyCLI
participant E2EAutomation
participant TauriRuntime
participant macOS
AIVerifyCLI->>E2EAutomation: dispatch close-to-tray
E2EAutomation->>TauriRuntime: invoke closeMainWindowToTray
TauriRuntime->>macOS: hide Dock icon and close WebView
macOS->>TauriRuntime: emit Reopen
TauriRuntime->>TauriRuntime: ensure main window
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
qdaxb
marked this pull request as ready for review
July 13, 2026 13:47
qdaxb
force-pushed
the
fix/wework-macos-dock-reopen
branch
from
July 13, 2026 13:50
56b5300 to
996c57f
Compare
This was referenced Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RunEvent::Reopenwithout visible windowsclose-to-trayAI verification action and document its usageRoot cause
The close-to-tray path destroyed the main window and changed
NSApplicationactivation policy. On older macOS versions that policy transition could leave the Dock icon visible. The application also did not handle the native reopen callback, so activating the remaining Dock icon could not recreate the destroyed main window.Impact
Closing Wework to the tray now removes its Dock icon while keeping the process running. If macOS still delivers a Dock/system reopen activation, Wework recreates and focuses the main window instead of leaving an unresponsive icon.
Validation
cargo fmt --checkcargo checkcargo test— 44 passedpnpm --filter wework typecheckUIElement; subsequent native activation initialized a new WebViewThe real-Tauri run used macOS 26.2. Dedicated older-macOS hardware was not available in this workspace.
Summary by CodeRabbit
New Features
Bug Fixes
Tests