Skip to content

fix(wework): resume blocked goals - #1914

Merged
qdaxb merged 1 commit into
mainfrom
fix/resume-blocked-goals
Jul 13, 2026
Merged

qdaxb merged 1 commit into
mainfrom
fix/resume-blocked-goals

Conversation

@qdaxb

@qdaxb qdaxb commented Jul 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • allow blocked runtime goals to show the existing resume control
  • retain pause restrictions for usage- and budget-limited goals
  • add coverage for resuming a blocked goal

Root cause

The goal status bar treated only paused goals as resumable, even though the local runtime can reactivate a blocked goal.

Validation

  • pnpm --filter wework exec vitest run src/components/chat/ChatInput.test.tsx --reporter=dot
  • Prettier, ESLint, TypeScript, and unit tests in the pre-push gate
  • Isolated Tauri: created a local goal, observed it enter blocked state, clicked Continue goal, and verified it became Goal continuing.

Summary by CodeRabbit

  • New Features

    • Added a resume control for blocked goals.
    • Blocked goals can now be resumed directly from the goal status bar.
  • Bug Fixes

    • Updated goal status controls to display the correct resume action and behavior for blocked goals.

@coderabbitai

coderabbitai Bot commented Jul 13, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: bfae7d7f-9907-451e-859e-6c53287f7e29

📥 Commits

Reviewing files that changed from the base of the PR and between f9045d4 and e201a45.

📒 Files selected for processing (2)
  • wework/src/components/chat/ChatInput.test.tsx
  • wework/src/components/chat/composer/GoalStatusBar.tsx
🚧 Files skipped from review as they are similar to previous changes (2)
  • wework/src/components/chat/composer/GoalStatusBar.tsx
  • wework/src/components/chat/ChatInput.test.tsx

📝 Walkthrough

Walkthrough

Blocked goals are treated as resumable in GoalStatusBar, including resume controls, labels, icons, handlers, and test identifiers. ChatInput tests verify the blocked-goal resume action and update status coverage.

Changes

Blocked Goal Resume

Layer / File(s) Summary
Resumable goal control behavior
wework/src/components/chat/composer/GoalStatusBar.tsx, wework/src/components/chat/ChatInput.test.tsx
Paused and blocked goals use resume behavior, and tests verify the blocked-goal resume button invokes onResumeGoal once while excluding blocked goals from absence assertions.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and accurately summarizes the main change: enabling blocked goals to resume.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/resume-blocked-goals

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qdaxb
qdaxb marked this pull request as ready for review July 13, 2026 07:53
@qdaxb
qdaxb force-pushed the fix/resume-blocked-goals branch from db693f1 to e201a45 Compare July 13, 2026 09:06
@qdaxb
qdaxb merged commit 7a84cee into main Jul 13, 2026
18 checks passed
@qdaxb
qdaxb deleted the fix/resume-blocked-goals branch July 13, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant