Repository navigation
[codex] stabilize Wework Codex runtime guidance - #1748
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (31)
📝 WalkthroughWalkthroughThis PR adds a "runtime guidance" feature allowing a queued user message to steer an active Codex turn without interrupting it. Backend gains a ChangesRuntime Guidance Feature
Estimated code review effort: 4 (Complex) | ~75 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant PaneSession as useWorkbenchPaneSession
participant Messaging as useWorkbenchRuntimeMessaging
participant BackendAPI
participant Executor
User->>PaneSession: send(input, {guideWhenBusy:true})
PaneSession->>PaneSession: split active assistant, insert guidance message
PaneSession->>Messaging: sendRuntimePaneGuidance(request)
Messaging->>BackendAPI: POST /guidance
BackendAPI->>Executor: runtime.tasks.guidance RPC
Executor->>Executor: wait for active Codex turn, steer_turn
Executor-->>BackendAPI: guidance/turn result
BackendAPI-->>Messaging: RuntimeGuidanceResponse
Messaging-->>PaneSession: {sent, code, error}
alt no_active_turn
PaneSession->>Messaging: fallback sendRuntimeMessage
end
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Root Cause
Wework inserted successful guidance messages only after the guidance request returned, while Codex could continue emitting assistant text during that request window. That text was already attached to the pre-guidance assistant, so live streaming could show assistant content before the user guidance even though a refresh reconstructed the transcript differently.
Validation
Summary by CodeRabbit
New Features
Bug Fixes