Repository navigation
Codex/increase claude timeout - #1632
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughProcess execution now uses per-engine timeouts, with a Claude Code-specific override and updated tests. Two frontend tests also switch from ChangesConfigurable process timeout and Claude-specific override
Frontend test interaction fixes
Sequence Diagram(s)sequenceDiagram
participant AgentProcessEngine
participant StreamProcessEngine
participant ProcessEngine
participant ProcessExecution
AgentProcessEngine->>StreamProcessEngine: create with timeout_seconds
StreamProcessEngine->>ProcessEngine: store timeout_seconds
ProcessEngine->>ProcessExecution: run_command / run_command_output / run_streaming_command_output with timeout_seconds
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/en/user-guide/ai-devices/local-device-support.md`:
- Around line 215-223: Adjust the heading level for the “Claude Code Execution
Timeout” subsection in the local-device-support docs so it uses `###` instead of
`####`, keeping the document hierarchy consistent with the allowed
`#`/`##`/`###` structure. Update the markdown heading in that subsection only,
and leave the surrounding content and code block unchanged.
In `@docs/zh/user-guide/ai-devices/local-device-support.md`:
- Around line 217-225: The “Claude Code 执行超时” subsection in the local device
support guide uses the wrong heading depth and should be changed from a
fourth-level heading to a third-level heading to match the docs hierarchy.
Update the markdown heading for this section to use `###` so it aligns with the
surrounding structure and the repository’s docs conventions, keeping the rest of
the content unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 1d73cf8f-9649-478b-ab8f-71bfae3d6fb2
📒 Files selected for processing (10)
docs/en/user-guide/ai-devices/local-device-support.mddocs/zh/user-guide/ai-devices/local-device-support.mdexecutor/src/agents/mod.rsexecutor/src/process/mod.rsexecutor/tests/agent_process_engine_contract.rsexecutor/tests/app_runtime_work_send_contract.rsexecutor/tests/claude_cancellation_contract.rsexecutor/tests/process_engine_contract.rswework/src/App.plugins.test.tsxwework/src/components/chat/FileChangesReviewPanel.test.tsx
| #### Claude Code Execution Timeout | ||
|
|
||
| When the local executor starts a Claude Code child process, it waits up to 1 hour by default. Long-running code generation, dependency installation, or file processing tasks can continue within that window. To tune the limit for a specific environment, set `WEGENT_CLAUDE_CODE_PROCESS_TIMEOUT_SECONDS` before starting the executor. This setting only affects Claude Code child processes, not the native Codex app-server path; Codex RPC timeouts are controlled by `WEGENT_CODEX_RPC_TIMEOUT_SECONDS`. | ||
|
|
||
| ```bash | ||
| export WEGENT_CLAUDE_CODE_PROCESS_TIMEOUT_SECONDS=7200 | ||
| wegent-executor | ||
| ``` | ||
|
|
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Use ### instead of #### for this subsection.
Line 215 breaks the repo’s required docs heading hierarchy; only #, ##, and ### are allowed here.
Suggested fix
-#### Claude Code Execution Timeout
+### Claude Code Execution TimeoutAs per coding guidelines, docs/**/*.{md,mdx}: "Use a consistent heading hierarchy: # for title, ## for sections, and ### for subsections."
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| #### Claude Code Execution Timeout | |
| When the local executor starts a Claude Code child process, it waits up to 1 hour by default. Long-running code generation, dependency installation, or file processing tasks can continue within that window. To tune the limit for a specific environment, set `WEGENT_CLAUDE_CODE_PROCESS_TIMEOUT_SECONDS` before starting the executor. This setting only affects Claude Code child processes, not the native Codex app-server path; Codex RPC timeouts are controlled by `WEGENT_CODEX_RPC_TIMEOUT_SECONDS`. | |
| ```bash | |
| export WEGENT_CLAUDE_CODE_PROCESS_TIMEOUT_SECONDS=7200 | |
| wegent-executor | |
| ``` | |
| ### Claude Code Execution Timeout | |
| When the local executor starts a Claude Code child process, it waits up to 1 hour by default. Long-running code generation, dependency installation, or file processing tasks can continue within that window. To tune the limit for a specific environment, set `WEGENT_CLAUDE_CODE_PROCESS_TIMEOUT_SECONDS` before starting the executor. This setting only affects Claude Code child processes, not the native Codex app-server path; Codex RPC timeouts are controlled by `WEGENT_CODEX_RPC_TIMEOUT_SECONDS`. | |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/en/user-guide/ai-devices/local-device-support.md` around lines 215 -
223, Adjust the heading level for the “Claude Code Execution Timeout” subsection
in the local-device-support docs so it uses `###` instead of `####`, keeping the
document hierarchy consistent with the allowed `#`/`##`/`###` structure. Update
the markdown heading in that subsection only, and leave the surrounding content
and code block unchanged.
Source: Coding guidelines
| #### Claude Code 执行超时 | ||
|
|
||
| 本地 executor 启动 Claude Code 子进程时,默认最长等待 1 小时。长时间代码生成、依赖安装或文件处理任务可以在这个时间内继续运行。若需要为特定环境调整该限制,可在启动 executor 前设置 `WEGENT_CLAUDE_CODE_PROCESS_TIMEOUT_SECONDS`。该配置只影响 Claude Code 子进程,不影响 native Codex app-server;Codex RPC 超时由 `WEGENT_CODEX_RPC_TIMEOUT_SECONDS` 控制。 | ||
|
|
||
| ```bash | ||
| export WEGENT_CLAUDE_CODE_PROCESS_TIMEOUT_SECONDS=7200 | ||
| wegent-executor | ||
| ``` | ||
|
|
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Use ### instead of #### for this subsection.
Line 217 breaks the repo’s required docs heading hierarchy; only #, ##, and ### are allowed here.
Suggested fix
-#### Claude Code 执行超时
+### Claude Code 执行超时As per coding guidelines, docs/**/*.{md,mdx}: "Use a consistent heading hierarchy: # for title, ## for sections, and ### for subsections."
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| #### Claude Code 执行超时 | |
| 本地 executor 启动 Claude Code 子进程时,默认最长等待 1 小时。长时间代码生成、依赖安装或文件处理任务可以在这个时间内继续运行。若需要为特定环境调整该限制,可在启动 executor 前设置 `WEGENT_CLAUDE_CODE_PROCESS_TIMEOUT_SECONDS`。该配置只影响 Claude Code 子进程,不影响 native Codex app-server;Codex RPC 超时由 `WEGENT_CODEX_RPC_TIMEOUT_SECONDS` 控制。 | |
| ```bash | |
| export WEGENT_CLAUDE_CODE_PROCESS_TIMEOUT_SECONDS=7200 | |
| wegent-executor | |
| ``` | |
| ### Claude Code 执行超时 | |
| 本地 executor 启动 Claude Code 子进程时,默认最长等待 1 小时。长时间代码生成、依赖安装或文件处理任务可以在这个时间内继续运行。若需要为特定环境调整该限制,可在启动 executor 前设置 `WEGENT_CLAUDE_CODE_PROCESS_TIMEOUT_SECONDS`。该配置只影响 Claude Code 子进程,不影响 native Codex app-server;Codex RPC 超时由 `WEGENT_CODEX_RPC_TIMEOUT_SECONDS` 控制。 | |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/zh/user-guide/ai-devices/local-device-support.md` around lines 217 -
225, The “Claude Code 执行超时” subsection in the local device support guide uses
the wrong heading depth and should be changed from a fourth-level heading to a
third-level heading to match the docs hierarchy. Update the markdown heading for
this section to use `###` so it aligns with the surrounding structure and the
repository’s docs conventions, keeping the rest of the content unchanged.
Source: Coding guidelines
Summary by CodeRabbit
WEGENT_CLAUDE_CODE_PROCESS_TIMEOUT_SECONDS.