Repository navigation
[codex] Preserve Codex runtime session IDs - #1614
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (10)
📝 WalkthroughWalkthroughAdds end-to-end ChangesThread ID propagation through runtime task send flow
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…sion-id # Conflicts: # wework/src/api/local/localServices.ts
Summary
thread/startedis observed.runtimeHandle.threadIdthrough Wework local runtime task normalization and task address reconciliation.localTaskId, including after cancellation and nested address sends.Why
Follow-up Wework sends could fall back to
localTaskIdwhen the real Codex thread id was not available in the request path. Codex expects UUID-like thread ids, so visible local task ids could trigger invalid session errors.Validation
cargo test --manifest-path executor/Cargo.toml --test app_runtime_work_send_contractcargo fmt --manifest-path executor/Cargo.toml -- --checkpnpm --dir wework exec vitest run src/api/local/localServices.test.ts src/features/workbench/workbenchReducer.test.ts src/features/workbench/workbenchRuntimeHelpers.test.tspnpm --dir wework exec tsc -bpnpm --dir wework exec prettier --check src/api/local/localServices.ts src/api/local/localServices.test.ts src/features/workbench/workbenchReducer.ts src/features/workbench/workbenchReducer.test.ts src/features/workbench/workbenchRuntimeHelpers.ts src/features/workbench/workbenchRuntimeHelpers.test.tsAI_VERIFIED=1: Wework full test suite, executorcargo fmt --check,cargo test --all-features, andcargo clippypassed; docs were checked and already cover the runtimeHandle/threadId contract.Summary by CodeRabbit
New Features
Bug Fixes