Skip to content

fix(wework): improve desktop chat scroll affordances - #1260

Merged
qdaxb merged 1 commit into
wecode-ai:mainfrom
FicoHu:codex/wework-scroll-affordances
Jun 4, 2026
Merged

qdaxb merged 1 commit into
wecode-ai:mainfrom
FicoHu:codex/wework-scroll-affordances

Conversation

@FicoHu

@FicoHu FicoHu commented Jun 4, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes

    • Corrected backspace deletion behavior in the composer when mentions are present.
  • Style

    • Enhanced scroll-to-bottom button styling and positioning when the floating composer is active.
    • Updated floating composer backdrop appearance.

@coderabbitai

coderabbitai Bot commented Jun 4, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: af9b9195-c7ad-4b3b-91ba-78fb6abcdec8

📥 Commits

Reviewing files that changed from the base of the PR and between d202e4d and f859461.

📒 Files selected for processing (4)
  • wework/src/components/chat/ScrollableMessageArea.tsx
  • wework/src/components/chat/composer/ComposerTextarea.tsx
  • wework/src/components/layout/DesktopWorkbenchLayout.test.tsx
  • wework/src/components/layout/DesktopWorkbenchMain.tsx
💤 Files with no reviewable changes (1)
  • wework/src/components/chat/composer/ComposerTextarea.tsx

📝 Walkthrough

Walkthrough

This PR refactors scroll-to-bottom button styling in the desktop workbench layout by introducing a customizable prop in ScrollableMessageArea, centralizing CSS constants in DesktopWorkbenchMain, and adding a backdrop div for the floating composer. It also removes an unused parameter from a text area helper function and updates test assertions accordingly.

Changes

Scroll Button Styling and Desktop Layout Refactor

Layer / File(s) Summary
Scroll Button Prop Interface and Rendering
wework/src/components/chat/ScrollableMessageArea.tsx
ScrollableMessageArea accepts optional scrollButtonClassName prop and merges it with default button styles via cn() to enable external customization of scroll-to-bottom button appearance.
Desktop Layout Styling Constants
wework/src/components/layout/DesktopWorkbenchMain.tsx
DesktopWorkbenchMain defines file-scope CSS class constants for floating composer backdrop and scroll-to-bottom button variants (queued and non-queued states) to replace previously hardcoded class selections.
Desktop Layout Component and Backdrop Integration
wework/src/components/layout/DesktopWorkbenchMain.tsx
DesktopWorkbenchMain uses CSS constants for button styling, adds dynamic bottom padding for ScrollableMessageArea based on queued/guidance content, and introduces a backdrop div for the floating composer with test attributes.
Layout Tests and Scroll Button Positioning
wework/src/components/layout/DesktopWorkbenchLayout.test.tsx
DesktopWorkbenchLayout test suite updates floating composer backdrop assertions, adds a test verifying scroll-to-bottom button positioning with mocked scroll geometry, and adjusts queued-messages spacing expectations.

Text Area Helper Cleanup

Layer / File(s) Summary
Backspace Helper Parameter Cleanup
wework/src/components/chat/composer/ComposerTextarea.tsx
Simplifies findBackspaceSkillMentionDeletionRange helper by removing unused value parameter from function definition and call site, aligning signature with actual usage.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • wecode-ai/Wegent#1254: Modifies MessageList.tsx and chat UI to support richer message rendering and queue/guidance features, indicating direct code-level relationship with floating composer and layout changes.

Suggested reviewers

  • qdaxb

Poem

🐰 Styling refined with constants so clear,
Scroll buttons dance, the backdrop's near!
Props flow smooth through each composition,
Desktop layouts reach their new fruition! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'improve desktop chat scroll affordances' accurately describes the main changes across all modified files, which involve adding scroll-to-bottom button styling customization and positioning improvements for the desktop chat interface.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@qdaxb
qdaxb merged commit a2f5aa0 into wecode-ai:main Jun 4, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants