Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mixin: Property 'messageRawPayload' of exported class expression may not be private or protected.ts(4094) #155

Closed
huan opened this issue Oct 14, 2021 · 1 comment
Closed

Mixin: Property 'messageRawPayload' of exported class expression may not be private or protected.ts(4094) #155

huan opened this issue Oct 14, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@huan
Copy link
Member

huan commented Oct 14, 2021 •
edited
Loading

The Problem

Mixin does not allow the use of protected and private with property/method

The Solution

  1. Change them with public and a _ prefix?
  2. Provide a PuppetInterface by defining a ProtectedMethods type to calculate from Omit<Puppet, ProtectedMethods>

Links
@huan huan added the enhancement New feature or request label Oct 14, 2021
@huan huan mentioned this issue Oct 14, 2021
Merged
huan added a commit that referenced this issue Oct 14, 2021
@huan
change protected to jsdoc (#155)
5ca2fae
@huan huan mentioned this issue Oct 14, 2021
Closed
huan added a commit that referenced this issue Oct 15, 2021
@huan
Init Mixins (#154)
9d4a8dd 
* create PayloadCache class

* init mixins

* add mixin docs

* code clean

* change protected to jsdoc (#155)

* add CacheMixin & WatchdogMin with PuppetSkelton

* add CacheMixin & WatchdogMin with PuppetSkelton

* clean

* follow mixin design (#156)

* Create PuppetError classes (#159)

* split all code into mixins

* fix memory

* fix

* fix memory

* 0.49.4

* clean

* 0.49.5

* rename PuppetError -> GError

* rename PuppetError -> GError

* 0.49.6

* clean code

* 0.49.7
huan added a commit that referenced this issue Oct 15, 2021
@huan
add PuppetInterface (#155)
5bbf372
@huan
Copy link
Member Author

huan commented Oct 15, 2021

Finally, we use a PuppetInterface to remove the protected methods.

@huan huan closed this as completed Oct 15, 2021
huan added a commit that referenced this issue Oct 16, 2021
@huan
add mixin protected properties tests (#155)
56ce088
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@huan