-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[How to guides] Whatsapp section #1106
Conversation
vasvi-sood
commented
Jul 17, 2021
•
edited
Loading
edited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved PR with suggested changes. If you could have a little more explanation to the header section, it can become prefect PR, rest everything is perfect :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you modify according to the advice I gave in #1098 ? Thank you.
title: Deploy in Whatsapp | ||
--- | ||
|
||
Whatsapp is the most popular IM platform, so this how to guide focusses to deploy the bot in Whatsapp locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: focuses on deploying
Sure |
All changes have been made. Kindly review it @proudofsimin and @Rohitesh-Kumar-Jain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- docusaurus/static/img/docs/howto/IM_platform/deploy-whatsapp.webp
+ docusaurus/static/img/docs/howto/deploy-whatsapp/deploy-whatsapp.webp
All necessary changes have been made. Kindly review it @huan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for adding this whatsapp how-to guide!
Please follow my reviews and resolve the conflicts, then I believe it's ready to go.
|
||
<li> Create a new folder `src` and add a file `my-bot.js`. Add your custom functions to the code snippet below:</li> | ||
|
||
```bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here should be ts
instead of bash
<li> Create a new folder `src` and add a file `my-bot.js`. Add your custom functions to the code snippet below:</li> | ||
|
||
```bash | ||
const { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change them from CommonJS require
to ESM import
.
See: #1275
@vasvi-sood and @abhishek-iiit pls solve the merging conflict, and help yourself in merging the PR |