Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[How to guides] Whatsapp section #1106

Merged
merged 17 commits into from
Sep 13, 2021

Conversation

vasvi-sood
Copy link
Contributor

@vasvi-sood vasvi-sood commented Jul 17, 2021

whatsapp1
whatsapp2
whatsapp3

@vasvi-sood vasvi-sood added the how to guide PR related to How-to-Guide section label Jul 17, 2021
@vasvi-sood vasvi-sood requested a review from a team as a code owner July 17, 2021 09:13
Copy link
Member

@abhishek-iiit abhishek-iiit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved PR with suggested changes. If you could have a little more explanation to the header section, it can become prefect PR, rest everything is perfect :)

Copy link
Contributor

@proudofsimin proudofsimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you modify according to the advice I gave in #1098 ? Thank you.

title: Deploy in Whatsapp
---

Whatsapp is the most popular IM platform, so this how to guide focusses to deploy the bot in Whatsapp locally.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: focuses on deploying

@vasvi-sood
Copy link
Contributor Author

Could you modify according to the advice I gave in #1098 ? Thank you.

Sure

@vasvi-sood
Copy link
Contributor Author

vasvi-sood commented Jul 27, 2021

All changes have been made. Kindly review it @proudofsimin and @Rohitesh-Kumar-Jain

Copy link
Contributor

@proudofsimin proudofsimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- docusaurus/static/img/docs/howto/IM_platform/deploy-whatsapp.webp 
+ docusaurus/static/img/docs/howto/deploy-whatsapp/deploy-whatsapp.webp 

@vasvi-sood
Copy link
Contributor Author

- docusaurus/static/img/docs/howto/IM_platform/deploy-whatsapp.webp 
+ docusaurus/static/img/docs/howto/deploy-whatsapp/deploy-whatsapp.webp 

All necessary changes have been made. Kindly review it @huan

Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for adding this whatsapp how-to guide!

Please follow my reviews and resolve the conflicts, then I believe it's ready to go.


<li> Create a new folder `src` and add a file `my-bot.js`. Add your custom functions to the code snippet below:</li>

```bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here should be ts instead of bash

<li> Create a new folder `src` and add a file `my-bot.js`. Add your custom functions to the code snippet below:</li>

```bash
const {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change them from CommonJS require to ESM import.

See: #1275

@Rohitesh-Kumar-Jain
Copy link
Contributor

@vasvi-sood and @abhishek-iiit pls solve the merging conflict, and help yourself in merging the PR

@vasvi-sood vasvi-sood merged commit d2927f9 into wechaty:master Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoD 2021 how to guide PR related to How-to-Guide section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants