This repository was archived by the owner on Sep 21, 2023. It is now read-only.
Make it possible to first run the import and then configure the bot
#28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Septias
approved these changes
Jun 4, 2023
`increase_get_serial()` is called when `import` CLI command is used. If the bot is not configured, previously it stored an incomplete config with only the `serial` field. Such bot config cannot be deserialized into `BotConfig` structure afterwards. The function is changed not to store the serial and always return 1 until the bot is started at least once and users get a chance to receive an update.
link2xt
force-pushed
the
link2xt/run-after-import
branch
from
51d3534 to
0d3442b
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
importon an unconfigured bot stored incomplete config in the databaseand the bot did not start afterwards. See my comment at #26 (comment)
I have now changed
increase_get_serial()not to store the serial at all, so until the bot is started the serial virtually stays at "1".The test check that it is possible to run
importwith example apps, then start the bot and receive a list of 4 apps.The PR consists of two commits with descriptions, please don't squash. #26 was also not supposed to be squashed btw. Ideally just let me merge my own PRs.