Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1839: Prevent keypress events on user input elements #1840

Merged

Conversation

subins2000
Copy link
Contributor

@subins2000 subins2000 commented Jul 17, 2020

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:

What changes did you make? (Give an overview)
A simple copy of line from the previous function

Which issue (if any) does this pull request address?
Fixes #1839

Is there anything you'd like reviewers to focus on?

Copy link
Member

@alxhotel alxhotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Copy link
Contributor

@mathiasvr mathiasvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hicom150 hicom150 merged commit 60b4365 into webtorrent:master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pressing 'f' toggles fullscreen everywhere, even in inputs
5 participants