Added QR code generation

[joshterrill]

This is in place of #104

And uses the kjua library that was recommended in #94

[joshterrill]

@feross The standard test is failing on the ci because I'm using location as a means of getting the domain that instant.io is running on, and location is not specifically defined anywhere. Is there a better way of getting the current domain in this app?

[willstott101]

You have to use window.location to make standard happy.

[kaotisk-hund]

Hi everyone, I see on my tests that node v18 passes the test while v14 doesn't.
Log output:

standard: Unexpected linter output:                                                                                                            [70/529]
                                                                           
Error: EACCES: permission denied, scandir '/proc/tty/driver'                                                                                           
    at Object.readdirSync (fs.js:1048:3)                                                                                                               
    at readdirSafeSync (/node_modules/eslint/lib/cli-engine/file-enumerator.js:140:19)                                                                 
    at FileEnumerator._iterateFilesRecursive (/node_modules/eslint/lib/cli-engine/file-enumerator.js:434:29)                                           
    at _iterateFilesRecursive.next (<anonymous>)                           
    at FileEnumerator._iterateFilesRecursive (/node_modules/eslint/lib/cli-engine/file-enumerator.js:487:33)                                           
    at _iterateFilesRecursive.next (<anonymous>)                           
    at FileEnumerator._iterateFilesRecursive (/node_modules/eslint/lib/cli-engine/file-enumerator.js:487:33)                                           
    at _iterateFilesRecursive.next (<anonymous>)                           
    at FileEnumerator._iterateFilesRecursive (/node_modules/eslint/lib/cli-engine/file-enumerator.js:487:33)                                           
    at _iterateFilesRecursive.next (<anonymous>)                           
                                                                           
If you think this is a bug in `standard`, open an issue: https://github.com/standard/standard/issues                                                   
npm ERR! Test failed.  See above for more details.

This is reproduced with the window.location.origin, under docker.io/library/node:14 using podman as container.

[kaotisk-hund]

The <div id="qr-code"></div> is output inside a <p> element literally displaying the tag unrendered.

[kaotisk-hund]

That's my first review of code, I hope it helps

[kaotisk-hund]

This should be changed to util.unsafeLog

[kaotisk-hund]

According to suggestion below we won't need this line

Suggested change

util.log('<div id="qr-code"></div>')

[kaotisk-hund]

I am really unsure if you need to encapsulate to document.getElementById into util.log. Simply leaving it out produces the same result cause you are already selecting the "qr-code" id div and putting stuff there.

[joshterrill]

This is a pretty old PR request, happy to make the changes to it. I do remember the templating being a little weird when trying to reference document outside of util.log because (at least at the time), document would get seen as undefined by the tests.

[kaotisk-hund]

Actually, for multiple "uploads" in the implementation you made you putting the qr code on the original first drawn div.
You could replace both lines with

Suggested change

	util.log(document.getElementById('qr-code').appendChild(kjua({text: location.origin + '/#' + torrent.infoHash, crisp: true})))
	util.unsafeLog(kjua({
	text: window.location.origin + '/#' + torrent.infoHash,
	crisp: true
	}).outerHTML)

This will output "in place" each time you make an upload,underneath the buttons, above the content preview (if any).

[kaotisk-hund]

@joshterrill I feel like the QR codes are a feature to help adoption and provide ease of use. I think it's important, furthermore, it's not resolved in other PRs. Personally, I just stroll through repositories I like and try to help in whichever way I can. So, if you still wish to make this contribution, here is my review 😃 I guess @feross should also agree to push this, but I saw it was stuck because of a test failing (standard). The error I post I was getting is about wrong permissions on podman in my attempt to replicate the "testing" method from the repo (node 14, ubuntu latest). I am not affiliated with the development team, so my opinion is as good as that can be. Cheers!

[joshterrill]

Yeah I'm good to make these changes, would love to see this implemented as well. You'll see in this PR that I asked a question to resolve the issue with the standard tests not recognizing javascript window objects in the node environment, and it went unanswered for two years. So I hope that we can resolve this! I also see some of the suggestions you made (like util.unsafelog) were things that didn't even exist in the repo (as far as I can tell) at the time that this code was originally written, so that's cool. I'll take a look at this today and get back to you. Thanks.