Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix esm loader #253

Merged
merged 5 commits into from
Sep 2, 2022
Merged

Fix esm loader #253

merged 5 commits into from
Sep 2, 2022

Conversation

andrasbacsai
Copy link
Contributor

@andrasbacsai andrasbacsai commented Sep 2, 2022

This added a nasty feature (bug?) to the latest node versions (16/18), causing us to have this error in react-sdk:

@webstudio-is/react-sdk:build: Error [ERR_LOADER_CHAIN_INCOMPLETE]: "esbuild-node-loader 'resolve'" did not call the next hook in its chain and did not explicitly signal a short circuit. If this is intentional, include `shortCircuit: true` in the hook's return.

Now it works.

Github Actions will be fixed with this.

@vercel
Copy link

vercel bot commented Sep 2, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
webstudio-designer ❌ Failed (Inspect) Sep 2, 2022 at 7:24PM (UTC)

@andrasbacsai andrasbacsai marked this pull request as ready for review September 2, 2022 12:56
Copy link
Member

@kof kof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove the previous package we use everywhere, but yes, lets go for it

@andrasbacsai andrasbacsai merged commit af049f0 into main Sep 2, 2022
@kof kof deleted the fix-esm-loader branch October 21, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants