Skip to content

audio: use replaceTrack for "hard" mute #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

audio: use replaceTrack for "hard" mute #1009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/content/peerconnection/audio/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ <h1><a href="//webrtc.github.io/samples/" title="WebRTC samples homepage">WebRTC
<option value="PCMU">PCMU</option>
</select>
<button id="callButton">Call</button>
<button id="hangupButton">Hang Up</button>
<button id="muteButton" disabled>Mute</button>
<button id="hangupButton" disabled>Hang Up</button>
</div>
<div class="graph-container" id="bitrateGraph">
<div>Bitrate</div>
Expand Down
25 changes: 24 additions & 1 deletion src/content/peerconnection/audio/js/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,14 @@
var audio2 = document.querySelector('audio#audio2');
var callButton = document.querySelector('button#callButton');
var hangupButton = document.querySelector('button#hangupButton');
var muteButton = document.querySelector('button#muteButton');
var codecSelector = document.querySelector('select#codec');
hangupButton.disabled = true;
callButton.onclick = call;
hangupButton.onclick = hangup;
muteButton.onclick = toggleMute;

var supportsReplaceTrack = window.RTCRtpSender &&
'replaceTrack' in RTCRtpSender.prototype;
var pc1;
var pc2;
var localStream;
Expand Down Expand Up @@ -126,6 +129,7 @@ function gotDescription2(desc) {
desc.sdp = forceChosenAudioCodec(desc.sdp);
pc1.setRemoteDescription(desc).then(
function() {
muteButton.disabled = !supportsReplaceTrack;
},
onSetSessionDescriptionError
);
Expand All @@ -144,10 +148,29 @@ function hangup() {
pc1 = null;
pc2 = null;
hangupButton.disabled = true;
muteButton.disabled = true;
callButton.disabled = false;
codecSelector.disabled = false;
}

function toggleMute() {
var sender = pc1.getSenders()[0];
var p;
if (!sender.track) {
trace('re-adding audio track');
p = sender.replaceTrack(localStream.getAudioTracks()[0]);
} else {
trace('replacing audio track with null');
p = sender.replaceTrack(null);
}
p.then(function() {
console.log('replaced track');
})
.catch(function(err) {
console.error('during replaceTrack', err);
});
}

function gotRemoteStream(e) {
if (audio2.srcObject !== e.streams[0]) {
audio2.srcObject = e.streams[0];
Expand Down