This repository has been archived by the owner on May 13, 2024. It is now read-only.
Improved app.yaml #425
Merged
Improved app.yaml #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaptenJansson
suggested changes
Mar 3, 2017
src/app_engine/app.yaml
Outdated
| @@ -55,10 +53,6 @@ libraries: | |||
| env_variables: | |||
| BYPASS_JOIN_CONFIRMATION: false | |||
| # Only change these while developing, do not commit to source! | |||
| # Use appcfg.py --env_variable=CALLSTATS_APP_ID:ID \ | |||
There was a problem hiding this comment.
We want to keep these as we do use them when we deploy AppRTC. This will save us from having internal documentation. But you are correct that gcloud does not have a way to do this hence why we still use appcfg to deploy. Gcloud is used everywhere else though.
|
Done |
KaptenJansson
approved these changes
Mar 6, 2017
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest documentation on app.yaml recommends removing application and version element.
https://cloud.google.com/appengine/docs/standard/python/config/appref
At least for my case, gcloud would complain if these elements are present.
For setting up environment variables, I haven't found gcloud equivalent of appcfg.py --env_variable.
Since it is not clear for someone not familiar with app engine that appcfg.py is not available from the new Google Cloud SDK, I would say removing these instructions reduces confusion.