Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

wrong code make apprtc not work without ice server #437

Closed
danhdevelop opened this issue Apr 28, 2017 · 1 comment
Closed

wrong code make apprtc not work without ice server #437

danhdevelop opened this issue Apr 28, 2017 · 1 comment

Comments

@danhdevelop
Copy link

The code in apprtc.py at line 282:

if len(ice_server_base_url) > 0:
    ice_server_url = constants.ICE_SERVER_URL_TEMPLATE % \
        (ice_server_base_url, constants.ICE_SERVER_API_KEY)
else:
    ice_server_base_url = ''

in the else should be: ice_server_url=''
MirkoBonadei added a commit that referenced this issue Apr 28, 2017
@MirkoBonadei
Fixing variable name
3850527 
As reported in [1], AppRTC does not work without an ICE server because
of a wrong assignment.

This pull reuqest should fix.

[1] - #437
@MirkoBonadei MirkoBonadei mentioned this issue Apr 28, 2017
Merged
@KaptenJansson
Copy link
Contributor

Thanks for filing, this is now fixed.

BlackNightFury added a commit to BlackNightFury/webrtc-demo-apprtc that referenced this issue Oct 18, 2017
@BlackNightFury
Fixing variable name
58e1d4b 
As reported in [1], AppRTC does not work without an ICE server because
of a wrong assignment.

This pull reuqest should fix.

[1] - webrtc/apprtc#437
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KaptenJansson @danhdevelop