Upgrade lit + shoelace to reduce build size #938
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces the number of lit versions bundled in the app. Related to #378 but does not fully resolve the issue, since there's still two versions. Needs more investigation as to which package has lit bundled in the dist (se note)
Comparison
Versions bundled
Before:
After:
Build size
Before:
After:
Note
Although running
yarn install
only installs a single version of lit, there are still two versions in the final build, which indicates lit is bundled in one of the packages. Verified that single version of lit is installed withyarn why lit
:I think it's worth merging this PR in while investigating for the reduced overall bundle size and upgraded versions.