Add Karma configuration from Angular plugin configuration #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
davidlj95
commented
Dec 20, 2024
|
|
||
| export type ConfigFile = (config: Config) => void; | ||
| export const loadConfig = (configFile: ConfigFile): ConfigOptions | undefined => { | ||
| if (typeof configFile !== 'function') return; |
There was a problem hiding this comment.
Added this in order to allow empty configuration files for test fixtures
davidlj95
commented
Dec 20, 2024
| ['karma-jasmine', 'karma-chrome-launcher', 'karma-jasmine-html-reporter', 'karma-coverage'], | ||
| options.manifest.devDependencies | ||
| ) | ||
| .forEach(inputs.add, inputs); |
There was a problem hiding this comment.
Don't like the .forEach(inputs.add, inputs). But doesn't work without the latest inputs argument to specify this. And a for loop (as forEach is forbidden by Biome linter) looks too much 🤷 happy to change if someone else is unhappy too
There was a problem hiding this comment.
Agreed, this is fine really
davidlj95
force-pushed
the
angular-plugin-karma-config
branch
from
6161030 to
ba45938
Compare
|
Great, plugins use each other all over the place and it's chaotic and beautiful :) |
|
🚀 This pull request is included in v5.42.0. See Release 5.42.0 for release notes. Using Knip in a commercial project? Please consider becoming a sponsor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular allows running tests using Karma via the
@angular-devkit/build_angular:karmabuilder. However, configuration in Angular CLI workspace (akaangular.json) using that builder to run tests using Karma isn't taken into account as Karma configuration. But this is something that comes built-in when creating a fresh Angular project. This PR aims to take into account that builder configuration forknip.To do so:
helpers.ts. In the same fashion that XO uses some ESLint helpers. The code to load a configuration file has been moved there too to keep clean theindex.tsfile.karmaConfigin builder options is used to: