Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update entry/project defaults with production mode #861

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

davidlj95
Copy link
Contributor

@davidlj95 davidlj95 commented Nov 29, 2024

Defaults that appear in docs are not exactly the defaults used.

project defaults in docs do not include the final ! . Hence readers may understand all files are not production files by default.

Updates defaults found in docs to reflect the actual defaults used by the implementation.

Also sorts index,cli,main to match implementation to be nitty :P

Btw, didn't find any place in docs saying that all project files are considered production files by default. Should that be added somewhere? Or it's this new defaults update enough maybe?

@webpro
Copy link
Collaborator

webpro commented Dec 2, 2024

Thanks, David! Fully on board with the changes.

Btw, didn't find any place in docs saying that all project files are considered production files by default. Should that be added somewhere? Or it's this new defaults update enough maybe?

Good point, I'll add it to the production mode page shortly.

@webpro webpro merged commit 5f4e139 into webpro-nl:main Dec 2, 2024
@davidlj95 davidlj95 deleted the docs-project-are-production branch December 2, 2024 08:51
@webpro
Copy link
Collaborator

webpro commented Dec 2, 2024

🚀 This pull request is included in v5.38.4. See Release 5.38.4 for release notes.

Using Knip in a commercial project? Please consider becoming a sponsor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants