Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nx plugin doesn't look in package.json #598

Closed
alecmev opened this issue Apr 19, 2024 · 2 comments
Closed

Nx plugin doesn't look in package.json #598

alecmev opened this issue Apr 19, 2024 · 2 comments
Labels
feature request Feature request good first issue Good for newcomers

Comments

@alecmev
Copy link

alecmev commented Apr 19, 2024

Since Nx is more or less a replacement for good ol' scripts, I keep its project-specific configuration in package.json:

{
  "name": "foo",
  "nx": {
    "targets": {
      "fun": {
        "executor": "nx:run-commands",
        "options": {
          "command": "rimraf /"
        } 
      }
    }
  }
}

Currently the plugin doesn't check it for configuration:

const config = ['nx.json', 'project.json', '{apps,libs}/**/project.json'];

So Knip errors with:

Unused devDependencies
                   
rimraf              package.json

Just in case, it has the exact same shape as project.json, just one level deeper, under nx.

@alecmev alecmev added the bug Something isn't working label Apr 19, 2024
@alecmev alecmev changed the title The Nx plugin doesn't look in package.json Nx plugin doesn't look in package.json Apr 19, 2024
@webpro webpro added good first issue Good for newcomers feature request Feature request and removed bug Something isn't working labels Apr 19, 2024
ysknsid25 added a commit to ysknsid25/knip that referenced this issue Dec 16, 2024
ysknsid25 added a commit to ysknsid25/knip that referenced this issue Dec 16, 2024
ysknsid25 added a commit to ysknsid25/knip that referenced this issue Dec 16, 2024
webpro pushed a commit that referenced this issue Dec 16, 2024
@webpro
Copy link
Collaborator

webpro commented Dec 16, 2024

Fixed in #598.

@webpro webpro closed this as completed Dec 16, 2024
@alecmev
Copy link
Author

alecmev commented Dec 19, 2024

Nit: Fixed in #880 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Feature request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants