Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure that the callback function in module.hot.accept is parsed #11059

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

sokra
Copy link
Member

@sokra sokra commented Jun 18, 2020

fixes #11057

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
yes

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
nothing

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@pmmmwh
Copy link

pmmmwh commented Jun 19, 2020

Should this also apply to module.hot.dispose, module.hot.addDisposeHandler and module.hot.removeDisposeHandler 👀 ?

This fix will remove some hacks I needed to get React Fast Refresh working for webpack 5 😍

@sokra sokra merged commit 8aaff95 into master Jun 22, 2020
@sokra sokra deleted the bugfix/11057 branch June 22, 2020 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define Plugin not providing value within HMR callback
3 participants