Skip to content

docs(dev-server): Add documentation for serveIndex option - #2953

Merged
EugeneHlushko merged 3 commits into
webpack:masterfrom
EslamHiko:serve-index-documentation
Apr 19, 2019
Merged

docs(dev-server): Add documentation for serveIndex option#2953
EugeneHlushko merged 3 commits into
webpack:masterfrom
EslamHiko:serve-index-documentation

Conversation

@EslamHiko

Copy link
Copy Markdown
Contributor

add documentation for serveIndex option in this PR

webpack/webpack-dev-server#1752

@EugeneHlushko EugeneHlushko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but default goes into type section, also suggesting a rephrase

Comment thread src/content/configuration/dev-server.md Outdated
Comment thread src/content/configuration/dev-server.md Outdated
@EslamHiko

Copy link
Copy Markdown
Contributor Author

@EugeneHlushko some checks are failed, can I do something about them?

@EugeneHlushko

Copy link
Copy Markdown
Contributor

We are testing netlify deploy for previewing PRs, no need to do anything

@EugeneHlushko
EugeneHlushko merged commit 00e6773 into webpack:master Apr 19, 2019
@EugeneHlushko

Copy link
Copy Markdown
Contributor

Thanks!

@EugeneHlushko

Copy link
Copy Markdown
Contributor

in case anyone interested, here is our first preview: https://5cba05c10f05471a05b57258--webpackjsorg-pr-previews.netlify.com/

@EslamHiko

Copy link
Copy Markdown
Contributor Author

@EugeneHlushko You're Welcome 😄

@EslamHiko
EslamHiko deleted the serve-index-documentation branch April 19, 2019 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants