Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add build performance page #1506

Merged
merged 3 commits into from
Aug 11, 2017
Merged

add build performance page #1506

merged 3 commits into from
Aug 11, 2017

Conversation

sokra
Copy link
Member

@sokra sokra commented Aug 10, 2017

Add a page with build performance tips

skipjack
skipjack approved these changes Aug 10, 2017
View reviewed changes
Copy link
Collaborator

@skipjack skipjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sokra this is great and should knock out #16. I started to review and realized most of my comments were just grammar and formatting related so I just committed them myself. I hope you don't mind.

Once the build passes, I'll merge.

@skipjack skipjack merged commit 2b9b3e4 into master Aug 11, 2017
@skipjack skipjack deleted the feature/build-performance branch August 11, 2017 00:05
@skipjack skipjack mentioned this pull request Aug 11, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skipjack skipjack skipjack approved these changes

Assignees
No one assigned
Labels
Enhancement Guides
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sokra @skipjack