-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated getting-started.md #1350
Conversation
Small changes to conclusion for better flow into next guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes, aside from those this looks good.
content/guides/getting-started.md
Outdated
@@ -257,7 +257,8 @@ T> Custom parameters can be passed to webpack by adding two dashes between the ` | |||
|
|||
## Conclusion | |||
|
|||
Now that you have a basic build together, you should dig into the [basic concepts](/concepts) and [configuration](/configuration) to better understand webpack's design. The [API](/api) section digs into the various interfaces webpack offers. Or, if you'd prefer to learn by example, select the next guide from the list and continue building out this little demo we've been working on which should now look similar to this: | |||
Now that you have a basic build together you should move on to the next guide [`Asset Management`](/guides/asset-management) to learn about how to manage assets like images and fonts with webpack. By now, your project should look like this: | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop the extra line.
content/guides/getting-started.md
Outdated
@@ -257,7 +257,8 @@ T> Custom parameters can be passed to webpack by adding two dashes between the ` | |||
|
|||
## Conclusion | |||
|
|||
Now that you have a basic build together, you should dig into the [basic concepts](/concepts) and [configuration](/configuration) to better understand webpack's design. The [API](/api) section digs into the various interfaces webpack offers. Or, if you'd prefer to learn by example, select the next guide from the list and continue building out this little demo we've been working on which should now look similar to this: | |||
Now that you have a basic build together you should move on to the next guide [`Asset Management`](/guides/asset-management) to learn about how to manage assets like images and fonts with webpack. By now, your project should look like this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/learn about how/learn how
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might rephrase By now, your project should look like this:
to something like At this point, the project should look something like this:
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 🚀
Small changes to conclusion for better flow into next guide.