fix definition of webpack -p
#1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix definition of `webpack -p` command line option expansion, at the top of this page its missing the needed single quotes which are present down below. this caused me some grief ;) incidentally `--optimize-minimize --define process.env.NODE_ENV="'production'"` *doesnt* produce the same result as `-p` for me, only the first correctly causes react to build in production mode without the attedant warnings. this is with webpack 1.15.0 and react 15.6.1. I assume this is a doc issue rather than something i need to create as an issue on either react or webpack but let me know if im wrong here.
|
|
|
Hmmm well I think you are correct that the quotes are needed but will let @bebraw have the final say. Also, just as a general note, this repo is geared towards the latest major releases of webpack, i.e. v2 and v3. While I believe you're correction still stands, you should migrate to a newer version as soon as you can. There are a variety of other things documented on this site that will not work in |
|
Yup, better go with quotes I think. That said, I don't use the CLI myself but the fix looks valid. |
skipjack
approved these changes
Jun 29, 2017
|
@JonnieCache merged, but please see my comment above as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix definition of
webpack -pcommand line option expansion, at the top of this page its missing the needed single quotes which are present down below. this caused me some grief ;)incidentally
--optimize-minimize --define process.env.NODE_ENV="'production'"doesnt produce the same result as-pfor me, only the first correctly causes react to build in production mode without the attedent warnings. this is with webpack 1.15.0 and react 15.6.1. I assume this is a doc issue rather than something i need to create as an issue on either react or webpack but let me know if im wrong here.