-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev - Convert to PWA (checklist) #1400
Comments
Hoping to have a PR ready for Components naming convention refactor within 24 hours. (Depending on how my testing goes) Should WebP be used for image optimization? (Whenever that is to be done) How would that work when new images are added when a new sponsor is added, etc? |
@hulkish how's it going? |
@Jorybraun Sorry this took so long, here you go:
run it: git clone [email protected]:webpack/webpack.js.org.git
cd webpack.js.org
git checkout pwa-add-component-tests
yarn
yarn test |
Perfect, I will get started tonight. |
@hulkish are the checkboxes up to date, anything can be done ? I can pick up something |
FOIT is now in progress, the google fonts part will soon land in support on Google's side so we dont need to resort to hosting a copy of the current version of the font on our side. |
Most of the items closed, whats left is svgs. To inline them we can convert them to react components |
/src
dir. ( [PWA] rename components and move app specific code to /src #1490, fix(deploy): fix deploy script after restructuring #1538 )Score at least a 92 on lighthouse
Audits
section of chrome devtools.Create Web App Manifest
As described here https://developers.google.com/web/fundamentals/engage-and-retain/web-app-manifest/
Site appropriately informs the user when they're offline
The text was updated successfully, but these errors were encountered: