Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev - Convert to PWA (checklist) #1400

Open
10 of 13 tasks
hulkish opened this issue Jul 8, 2017 · 7 comments
Open
10 of 13 tasks

Dev - Convert to PWA (checklist) #1400

hulkish opened this issue Jul 8, 2017 · 7 comments

Comments

@hulkish
Copy link
Collaborator

hulkish commented Jul 8, 2017

Score at least a 92 on lighthouse

Create Web App Manifest

As described here https://developers.google.com/web/fundamentals/engage-and-retain/web-app-manifest/

Site appropriately informs the user when they're offline

@Dean-Coakley
Copy link

Hoping to have a PR ready for Components naming convention refactor within 24 hours. (Depending on how my testing goes)

Should WebP be used for image optimization? (Whenever that is to be done) How would that work when new images are added when a new sponsor is added, etc?
E.g Could that optimization be automated, or would we just force it to be done manually?

@Jorybraun
Copy link

Jorybraun commented Jul 9, 2017

@hulkish how's it going?

@hulkish hulkish self-assigned this Jul 9, 2017
@hulkish
Copy link
Collaborator Author

hulkish commented Jul 9, 2017

@Jorybraun Sorry this took so long, here you go:

run it:

git clone [email protected]:webpack/webpack.js.org.git
cd webpack.js.org
git checkout pwa-add-component-tests
yarn
yarn test

@Jorybraun
Copy link

Perfect,

I will get started tonight.

@EugeneHlushko
Copy link
Member

EugeneHlushko commented Feb 20, 2018

@hulkish are the checkboxes up to date, anything can be done ? I can pick up something

@EugeneHlushko
Copy link
Member

FOIT is now in progress, the google fonts part will soon land in support on Google's side so we dont need to resort to hosting a copy of the current version of the font on our side.

@EugeneHlushko
Copy link
Member

Most of the items closed, whats left is svgs. To inline them we can convert them to react components

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants