-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pre-pwa: refactor naming convention for react components #1395
Comments
@hulkish saw your slack message, but didn't get a chance to reply as I've been sick the last few days -- would you mind merging these four issues to one meta issue with a checklist with the four points? We can then link PRs within the checklist and mark things done as they are completed. Also, as mentioned on #1380, I would really like the issues to be mostly content-related. Re the proposed naming convention, I'm fine with that change. How is that related to making the site a PWA though? |
Also we should make sure we stay in sync as we port the site -- I'm not sure if switching to gatsby or phenomic tackles or conflicts with certain parts of this. |
@skipjack i dont think switching to gatsy or phenomic will conflict with what i have in mind - since i am primarily focused on the react + webpack.config.js areas of the app. Regarding the naming convention pwa dependency question.. It doesn't necessarily need to be so in order to convert to a PWA - but I figure it's a change made much easier before the actual conversion. |
I'd like to PR this but I'm not so knowledgeable to be honest. It should be very simple, right? |
@Dean-Coakley Yea, it's pretty straight forward.. just be sure to update the import paths with the changes as well. Ex: import Dropdown from './components/Dropdown/Dropdown'; |
@hulkish notification-bar -> NotificationBar or Notification-Bar ? |
|
@hulkish Sorry for more questions but:
Secondly, |
yes for jsx (an assumed extension). No for scss (not an assumed extension) For your second question: correct |
moving this to #1400 |
So, I've been talking to @TheLarkInn regarding converting webpack.js.org to be a PWA. So, this is the first of a few tasks I'm creating to lay out a plan towards that direction.
Measuring by the current usage of react; I'd like to refactor the naming convention of the components to use Pascal case.
For example, this is the current convention:
components/dropdown/dropdown.jsx
components/dropdown/dropdown-style.scss
With the proposed convention this would like:
components/Dropdown/Dropdown.jsx
components/Dropdown/Dropdown.scss
The text was updated successfully, but these errors were encountered: