Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to set the sockjs_url option (only sockjs) #4586

Merged
merged 2 commits into from
Sep 27, 2022

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Sep 27, 2022

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

To test it we should disable websocket supporting in headless chrome (but it is impossible), as an alternative solution we can allow to set all options for sockjs server, but sockjs is old and only for old IE and Opera, I don't think many developers support it now and we should spend time on it, really, so I tested it manually and all works fine, in the next major release we will remove sockjs

Motivation / Use-Case

fixes #4348

Breaking Changes

No

Additional Info

Should we document it?

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Base: 90.48% // Head: 91.96% // Increases project coverage by +1.48% 🎉

Coverage data is based on head (58a6806) compared to base (87c08f1).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4586      +/-   ##
==========================================
+ Coverage   90.48%   91.96%   +1.48%     
==========================================
  Files          16       16              
  Lines        1639     1655      +16     
  Branches      617      622       +5     
==========================================
+ Hits         1483     1522      +39     
+ Misses        142      122      -20     
+ Partials       14       11       -3     
Impacted Files Coverage Δ
lib/servers/SockJSServer.js 95.23% <80.00%> (-2.06%) ⬇️
lib/Server.js 93.64% <0.00%> (+2.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We may need to document this somewhere.

@alexander-akait alexander-akait merged commit 69a2fba into master Sep 27, 2022
@alexander-akait alexander-akait deleted the issue-4348 branch September 27, 2022 18:44
@alexander-akait
Copy link
Member Author

Yeah feel fre to update our docs 👍 And thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hardcoded sockjs iframe url
2 participants