fix: avoid connection when web socket server is not running - #3879
Merged
Conversation
alexander-akait
requested review from
anshumanv,
hiroppy,
knagaitsev and
snitin315
as code owners
September 24, 2021 16:18
Codecov Report
@@ Coverage Diff @@
## master #3879 +/- ##
==========================================
- Coverage 92.72% 92.63% -0.09%
==========================================
Files 14 14
Lines 1334 1345 +11
Branches 467 468 +1
==========================================
+ Hits 1237 1246 +9
- Misses 89 92 +3
+ Partials 8 7 -1
Continue to review full report at Codecov.
|
snitin315
previously approved these changes
Sep 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
yes
Motivation / Use-Case
fixes #3873
Breaking Changes
No
Additional Info
no