Skip to content

fix: polling usage in watchFiles option #3366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-akait merged 4 commits into from
May 31, 2021
Merged

fix: polling usage in watchFiles option #3366

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b446782
fix: polling usage in watchFiles
anshumanv May 29, 2021
a83228b
fix: polling usage in watchFiles
anshumanv May 29, 2021
ac61c7c
fix: polling tests
anshumanv May 31, 2021
152ebb5
fix: polling tests
anshumanv May 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -973,7 +973,7 @@ class Server {
// https://github.com/webpack/watchpack/blob/master/lib/DirectoryWatcher.js#L49
// this isn't an elegant solution, but we'll improve it in the future
// eslint-disable-next-line no-undefined
const usePolling = watchOptions.poll ? true : undefined;
const usePolling = !!watchOptions.poll || watchOptions.usePolling;
Comment thread
anshumanv marked this conversation as resolved.
Outdated
const interval =
typeof watchOptions.poll === 'number'
? watchOptions.poll
Expand Down