Skip to content

feat: support fn in headers option #3267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anshumanv merged 5 commits into from
May 11, 2021
Merged

feat: support fn in headers option #3267

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e578788
feat: support fn in headers option
anshumanv May 7, 2021
dfa8ad3
test: headers fn
anshumanv May 11, 2021
ccffdc8
test: headers fn
anshumanv May 11, 2021
590ac25
test: headers fn
anshumanv May 11, 2021
d03b7f7
Merge branch 'master' into headers-fn
anshumanv May 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions test/server/headers-option.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,32 @@ describe('headers option', () => {
});
});

describe('as a function', () => {
beforeAll((done) => {
server = testServer.start(
config,
{
headers: () => {return { 'X-Bar': ['key1=value1', 'key2=value2'] }},
port,
},
done
);
req = request(server.app);
});

afterAll(testServer.close);

it('GET request with headers as a function', (done) => {
// https://github.com/webpack/webpack-dev-server/pull/1650#discussion_r254217027
const expected = ['v7', 'v8', 'v9'].includes(
process.version.split('.')[0]
Comment thread
anshumanv marked this conversation as resolved.
Outdated
)
? 'key1=value1,key2=value2'
: 'key1=value1, key2=value2';
req.get('/main').expect('X-Bar', expected).expect(200, done);
});
});

describe('dev middleware headers take precedence for dev middleware output files', () => {
beforeAll((done) => {
server = testServer.start(
Expand Down