Skip to content

feat: consider file URLs in WebSocket URL creation #2890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kroko wants to merge 2 commits into from
Closed

feat: consider file URLs in WebSocket URL creation #2890

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b6c191
feat: consider file URLs in WebSocket URL creation
kroko Dec 1, 2020
f037beb
feat(client): file URLs in WebSocket URL creation
kroko Dec 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion client-src/clients/WebsocketClient.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,14 @@ const BaseClient = require('./BaseClient');
module.exports = class WebsocketClient extends BaseClient {
constructor(url) {
super();
this.client = new WebSocket(url.replace(/^http/, 'ws'));
this.client = new WebSocket(
((urlToChange) => {
let wsUrl = urlToChange;
wsUrl = wsUrl.replace(/^http/, 'ws');
wsUrl = wsUrl.replace(/^file/, 'ws');
return wsUrl;
})(url)
);
Comment thread
kroko marked this conversation as resolved.
Outdated

this.client.onerror = (err) => {
log.error(err);
Expand Down