Skip to content

Conversation

@alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

no need

Motivation / Use-Case

update express and remove workaround for wasm

Breaking Changes

No

Additional Info

No

@alexander-akait alexander-akait requested a review from hiroppy as a code owner May 17, 2019 11:55
Copy link
Member

@hiroppy hiroppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #1896 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1896      +/-   ##
=========================================
- Coverage   88.03%     88%   -0.03%     
=========================================
  Files          14      14              
  Lines         819     817       -2     
  Branches      260     259       -1     
=========================================
- Hits          721     719       -2     
  Misses         84      84              
  Partials       14      14
Impacted Files Coverage Δ
lib/Server.js 85.9% <ø> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a81ad2...e47dd1b. Read the comment docs.

@alexander-akait
Copy link
Member Author

CI green ⭐

@alexander-akait alexander-akait merged commit df9d09c into master May 17, 2019
@alexander-akait alexander-akait deleted the chore-update-express branch May 17, 2019 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants