Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix historyApiFallback+proxy combo #152

Merged
merged 1 commit into from
Apr 13, 2015

Conversation

Lendar
Copy link
Contributor

@Lendar Lendar commented Apr 12, 2015

Both contentBase: "http://url" and proxy are incompatible with historyApiFallback. This PR fixes that.

Steps to reproduce:

Setup webpack with config

var server = new WebpackDevServer(webpack(config), {
  historyApiFallback: true,
  proxy: {
    "/api/*": "http://localhost:3100/"
  }
})

Then, open /api/foo in browser.

Expected result: result from proxy is returned.
Actual result: index.html is returned.

sokra added a commit that referenced this pull request Apr 13, 2015
@sokra sokra merged commit 9241e4c into webpack:master Apr 13, 2015
@sokra
Copy link
Member

sokra commented Apr 13, 2015

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants