feat: add built in .env support #4392
Conversation
|
|
||
| const WebpackCLI = require("./webpack-cli"); | ||
|
|
||
| const runCLI = async (args: Parameters<IWebpackCLI["run"]>[0]) => { | ||
| // Load environment variables from .env files | ||
| try { |
There was a problem hiding this comment.
I'm not sure that we want the env plugin to be default without any configuration. We should check if an env flag passed to the CLI/API is present.
There was a problem hiding this comment.
I added a --env-file flag for loading in variables from env files into webpack.config.js, but I've made the env plugin added by default so env vars can be accessed from bundled code without having to add the DotenvWebpackPlugin.
Is this what you meant?
There was a problem hiding this comment.
@evenstensberg friendly ping :)
There was a problem hiding this comment.
I wonder if @alexander-akait could maybe have a look?
I see some recent activity, so just a thought.
If not, no stress 😄
There was a problem hiding this comment.
Yeah, I will look in near future
There was a problem hiding this comment.
@Sakib25800 could you maybe look at the conflicts in the mean time?
I am not sure how severe they are.
I just noticed them in the checks section.
- Load env vars at build time and run time
Add support for import.meta.env and introduce --env-file flag to load environment variables from .env files into the bundled files. - Support for import.meta.env in webpack builds - New --env-file CLI flag for specifying whether to load .env files for configuration - Renamed dotenv plugin for clarity
- Add documentation for the dotenv webpack plugin - Add --env-file flag to OPTIONS.md
Sakib25800
force-pushed
the
feature/env-support
branch
from
8ce2c9b to
b58b2a5
Compare
What kind of change does this PR introduce?
Feature:
.envfile support following Vite's conventionsWEBPACK_are exposed to Webpack-processed codewebpack.config.jsDid you add tests for your changes?
Will add
If relevant, did you update the documentation?
Will add
Summary
Closes #3747
Does this PR introduce a breaking change?
No
Other information
This is my first PR, so there'll probably be a few mistakes / many questions