Skip to content

fix: using new dev server API for v4 #2886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-akait merged 1 commit into from
Aug 13, 2021
Merged

fix: using new dev server API for v4 #2886

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions packages/serve/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,11 @@ class ServeCommand {
process.stdin.on("end", () => {
Promise.all(
servers.map((server) => {
if (typeof server.stop === "function") {
return server.stop();
}

// TODO remove in the next major release
return new Promise<void>((resolve) => {
server.close(() => {
resolve();
Expand Down Expand Up @@ -333,15 +338,20 @@ class ServeCommand {
server = new DevServer(compiler, devServerOptions);
}

server.listen(
devServerOptions.port,
devServerOptions.host,
(error): void => {
if (error) {
throw error;
}
},
);
if (typeof server.start === "function") {
await server.start();
} else {
// TODO remove in the next major release
server.listen(
devServerOptions.port,
devServerOptions.host,
(error): void => {
if (error) {
throw error;
}
},
);
}

servers.push(server);
} catch (error) {
Expand Down