Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test improve snapshot testing #2726

Closed
wants to merge 8 commits into from
Closed

Test improve snapshot testing #2726

wants to merge 8 commits into from

Conversation

alexander-akait
Copy link
Member

What kind of change does this PR introduce?

tests

Did you add tests for your changes?

It is tests

If relevant, did you update the documentation?

No need

Summary

Prepare for #2679

Does this PR introduce a breaking change?

No

Other information

  • Due webpack has cache for emitted assets we can't reuse the same directory for running webpack multiple times, for each test we need create unique directly
  • Also basic normalizers, they should be enough to test most of our tests

@alexander-akait alexander-akait requested a review from a team as a code owner May 19, 2021 13:43
evenstensberg
evenstensberg reviewed May 19, 2021
View reviewed changes
test/utils/test-utils.js Outdated Show resolved Hide resolved
test/utils/test-utils.js Outdated Show resolved Hide resolved
test/utils/test-utils.js Outdated Show resolved Hide resolved
test/utils/test-utils.js Outdated Show resolved Hide resolved
test/utils/test-utils.js Outdated Show resolved Hide resolved
evenstensberg
evenstensberg approved these changes Jun 5, 2021
View reviewed changes
Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@evenstensberg
Copy link
Member

Could you fix https://github.com/webpack/webpack-cli/pull/2726/checks?check_run_id=2754091275#step:7:9 ?

@alexander-akait
Copy link
Member Author

@evenstensberg it is not ready and will not work

@alexander-akait
Copy link
Member Author

And what's the point of picking on variable names when it's not ready? 😕

@alexander-akait alexander-akait deleted the test-improve-snapshot-testing branch April 21, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evenstensberg evenstensberg evenstensberg approved these changes

Assignees
No one assigned
Labels
PR: conflict PR: reviewed-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexander-akait @evenstensberg @webpack-bot