-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add mjs support #1786
feat: add mjs support #1786
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing
@evenstensberg Yes, because |
I think we don't need package, we can use this idea https://github.com/gulpjs/gulp-cli/blob/master/lib/shared/require-or-import.js |
@rishabh3112 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evenstensberg Please review the new changes. |
Same not working again locally. |
@rishabh3112 what is node you are use (version)? |
Tried on 12, 13 and 14. (I use fnm) |
Maybe something broken in |
Can't say for sure. Lets see CI, if still not passed then can you try checking out this branch and testing locally once? |
I tried with nvm in the past, no luck 😞 |
Yep would be great if @evilebottnawi can check once |
What kind of change does this PR introduce?
Support for
.mjs
configsDid you add tests for your changes?
If relevant, did you update the documentation?
Summary
It is extension of @anshumanv's PR with support for esm configs using
esm
package.Does this PR introduce a breaking change?
Other information
The standard
await import()
will not work as nodejs/node#32985 has been reverted.Using
esm
package in this PR to have esm interop