Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(output): add test case for defaults flag #1254

Merged
merged 3 commits into from
Feb 22, 2020

Conversation

anshumanv
Copy link
Member

What kind of change does this PR introduce?
Added a test case for --defaults flag

Did you add tests for your changes?
Yes

If relevant, did you update the documentation?
NA

Summary

  • Added a case when --defaults flag is used to indicate compiler to use webpack defaults.

Does this PR introduce a breaking change?
No

Other information

@anshumanv
Copy link
Member Author

anshumanv commented Feb 22, 2020

I think defaults tests can be moved a folder up(in it's own folder and can cover several cases like using this flag when a config is present, when files that webpack looks for by default is not present etc.) since they're not really output but rather a way to indicate compiler about the config, what say @ematipico?

@ematipico
Copy link
Contributor

Yes it makes totally sense! Feel free to move them around

@anshumanv
Copy link
Member Author

Thanks for the heads up! Will do. ✨

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@anshumanv
Copy link
Member Author

Will do it in a separate PR, have more tests and cleanup in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants