Project maintanance and typescript fix #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ematipico
force-pushed
the
feature/typescript
branch
from
693daf2
to
ba1e422
Compare
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
ematipico
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR introduces a bugfix/feature for typescript and it also bring some order inside the project structure.
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Not yet
Summary
Now all the packages that are written in using the same project structure:
lib/will contain the compiled codesrc/will contain the TypeScript filespackage.jsonhas been updated in order to upload only thelibpackage.jsonhas been updated in order to point as"main": "lib/index.js".gitignorehas been updated in order to ignore thelibfolderscripts/buildPackages.js)Created two new packages:
@webpack-cli/package-utilswhich will contain utilities about packages and processes. Here I put some repeated code. Everything should be there and it can be used by different packages@webpack-cli/loggerso all the packages can share the same instance of the same loggerAdded typescript support:
Inside
ConfigGroup.jsI added a small utility to register the typescript compiler.Does this PR introduce a breaking change?
No
Other information